How do Collection Editors get notified when a Collection Viewers Create a Merge Request?

ahackley · January 23, 2020, 5:04pm

When a Collection Viewer wants to update a collection, they can fork it and make their changes. Then they can create attempt to merge the changes, but they won’t be able to because their Collection Viewer role doesn’t allow them to. Which is perfect! However, how do Collection Editors get notified that a merge request has been created so that they can review the merge request and appropriately approve/deny it?

Thank you!

arlem · January 24, 2020, 5:32pm

Hey @ahackley!

We are currently working on implementing pull requests in Postman, we’ll be releasing this in stages but it should be available soon!
I’ve added your feedback on the github issue we’re using to track this feature but feel free to add more if you want:

github.com/postmanlabs/postman-app-support

Add enhanced merge tools to make merging similar to git pull requests

opened 01:37PM - 05 Jun 19 UTC

closed 08:27AM - 15 May 20 UTC

yossarian123

feature version-control fork+merge

With the ability to fork/comment/merge, Postman has some of the basic functional…ity of a git PR. However, the following capabilities would really help: - mark a merge as "needs work" - which will prevent the merge from taking place - show a list of comments along with the ability to toggle those comments as resolved - if there are any unresolved comments then postman would prevent the fork from being merged (unless there was an override by an admin) Our team is currently storing collections in git - when changes are made we modify the .json file and track a pull request directly in git. We'd like to move away from this and only use collections in team workspaces. The above enhancements would make the merge & collaborative features extremely useful for us.

ahackley · January 27, 2020, 2:40pm

Thank you @arlem! Exactly what I was looking for. I’ll keep an eye on the github request

trishay · February 3, 2020, 8:59pm

Exactly what our team needs. Excited for this!

arlem · February 25, 2020, 10:59am

@trishay @ahackley We’ve just pushed 7.19.1 enabling Pull Requests, give it a try and let us know if you have any feedback!

Screenshot 2020-02-25 at 10.58.09

trishay · February 25, 2020, 2:41pm

yay! will give it a try. Thanks!

trishay · February 25, 2020, 2:57pm

When I add a reviewer I got this error: {“errors”:[{“message”:“Unable to perform this action for pull request.”,“locations”:[{“line”:2,“column”:3}],“path”:[“createPullRequest”],“extensions”:{“code”:“FORBIDDEN”,“exception”:{“title”:“Something went wrong”,“code”:403}}}],“data”:{“createPullRequest”:null}}

When I leave the reviewer blank, I was able to create a PR without a problem.

trishay · February 25, 2020, 4:40pm

Also, when people view my PR they can’t see my changes get this error in the source

arlem · February 25, 2020, 6:08pm

@trishay Thanks for trying it out, are you forking the collection from a team workspace to your own workspace? From your workspace to a team workspace? Any steps to help me reproduce what you’re having would be helpful!

trishay · February 25, 2020, 6:21pm

So this are the steps I did:

From team workspace, share the collection to my workspace
From my workspace, fork the shared collection to my workspace

Thanks!

trishay · February 25, 2020, 8:26pm

It seems to work if the forked collection in my workspace gets shared in the team workspace

ankit-m · February 26, 2020, 11:32am

@trishay that’s right. The forked collection needs to be visible to your team members for them to review. That’s why the collection has to be shared in a team workspace before adding any team member as reviewers.

We will work on improving error messages so that this is obvious.

atchibabu.d · February 26, 2020, 2:55pm

@ankit-m Thanks for the information and the option given for “Pull request”. I am doing some analysis on this and got stuck while approving the pull request as a reviewer.

I dont know where to check, i have some thing to review?
Also, where can we see all the pull requests created by team members?
I think, we are missing some historical data from pull requests
How to track, if approver gives some feedback but, PR is not approved or Declined or Merged?
I thought, approver would receive an email notification with the PR information. But, that does not happen in my case. I hope, this is not expected

Could you please help me on the above points? i am very much interested to see this before going for the actual usage of pull requests (we are planning to use Git for VC purpose but, we are getting this from Postman itself and that is really helpful for postman users).

trishay · February 26, 2020, 5:20pm

Cool, thanks for the help!

anthony.dussaut · March 2, 2020, 11:12am

Hello, I’ve tried to get around this new feature for several days now and I’m not even close to the solution.

1 - I created a new team workspace and a new collection in it
2 - I forked this collection into my personal workspace
3 - I created a new request in my forked collection and created a pull request

Result:
Other team members can see my PR but are not able to see the changes as the source (my forked collection) is not visible for them

So, I shared my forked collection with the team workspace (and gave everyone Editor access):
Team members can now see the source but have no right to merge the PR.

I can’t see what to do to make it work…

csgo.expertt · March 5, 2020, 8:13pm

Has anyone succeeded in introducing changes? I tried to do everything as it was recommended in the start post but it does not seem to work properly for me. I would like to have this application for my company but I will need a detailed guide. Please redirect me to the source with this information. We are based on the map of area code 512. The program seems perfect for our team. We are keen to try it.